This repository was archived by the owner on May 24, 2022. It is now read-only.
cache: use optimized futexes on i386 and amd64 arch only#105
Open
vincentbernat wants to merge 1 commit intobumptech:masterfrom
Open
cache: use optimized futexes on i386 and amd64 arch only#105vincentbernat wants to merge 1 commit intobumptech:masterfrom
vincentbernat wants to merge 1 commit intobumptech:masterfrom
Conversation
Contributor
Author
|
Besides this, I was thinking about switching to autotools stuff. Is it something that you would agree with? This would make easier for the user to compile with the right options, this will also make easier to handle cases like this one. |
Optimized futexes are only available on i386 and amd64 on Linux since they use inline assembly. It is difficult to come with a generic way to tell which arch we are using from the Makefile and therefore, additional checks are put in the preprocessor before using those futexes.
|
Hi vincent, please check #109, it supports gcc atomic sync built-ins for other archs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimized futexes are only available on i386 and amd64 since they use
inline assembly. It is difficult to come with a generic way to tell
which arch we are using from the Makefile and therefore, additional
checks are put in the preprocessor before using those futexes.